Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete tls switcher. Add plugin and devfile registry links. #696

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Delete tls switcher. Add plugin and devfile registry links. #696

merged 2 commits into from
Mar 4, 2021

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Mar 2, 2021 •
edited by tolusha
Loading

What does this PR do?

Delete tls switcher. Add plugin and devfile registry links.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-1613

How to test this PR?

Install Eclipse Che using OLM installer. On the Openshift UI go to: Operators -> Installed operators -> Select and click on CheCluster item and take a look descriptions tab.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

@codecov
Copy link

codecov bot commented Mar 2, 2021 •
edited
Loading

Codecov Report

Merging #696 (8a2b87e) into master (9f241d0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   31.60%   31.60%           
=======================================
  Files          49       49           
  Lines        5369     5369           
=======================================
  Hits         1697     1697           
  Misses       3421     3421           
  Partials      251      251

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f241d0...8a2b87e. Read the comment docs.

@tolusha tolusha mentioned this pull request Mar 3, 2021
Closed
70 tasks
@mmorhun mmorhun removed their assignment Mar 3, 2021
tolusha
tolusha reviewed Mar 3, 2021
View reviewed changes
deploy/crds/org_v1_che_cr.yaml Outdated Show resolved Hide resolved
deploy/crds/org_v1_che_cr.yaml Outdated Show resolved Hide resolved
deploy/crds/org_v1_che_cr.yaml Outdated Show resolved Hide resolved
deploy/crds/org_v1_che_cr.yaml Outdated Show resolved Hide resolved
deploy/crds/org_v1_che_cr.yaml Outdated Show resolved Hide resolved
deploy/crds/org_v1_che_cr.yaml Outdated Show resolved Hide resolved
deploy/crds/org_v1_che_cr.yaml Outdated Show resolved Hide resolved
deploy/crds/org_v1_che_cr.yaml Outdated Show resolved Hide resolved
deploy/crds/org_v1_che_cr.yaml Outdated Show resolved Hide resolved
deploy/crds/org_v1_che_cr.yaml Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor

tolusha commented Mar 4, 2021

/retest

@AndrienkoAleksandr
Fix and improve CR, CRD.
f781194 
Delete tls switcher. Add plugin and devfile registry links. Remove some aren't popular fields from CR sample. Improve CR sample and CRD descriptions.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr force-pushed the improveCheClusterDescriptionOnTheOpenshiftUI branch from 6f5ab90 to f781194 Compare March 4, 2021 12:59
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@AndrienkoAleksandr
Update OLM bundle
8a2b87e 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr merged commit 80e33df into master Mar 4, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the improveCheClusterDescriptionOnTheOpenshiftUI branch March 4, 2021 16:23
@che-bot che-bot added this to the 7.27 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@mmorhun mmorhun mmorhun approved these changes

@flacatus flacatus Awaiting requested review from flacatus

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@tolusha tolusha

Labels
None yet
Projects
None yet
Milestone
7.27
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AndrienkoAleksandr @openshift-ci-robot @tolusha @mmorhun @che-bot